search

RMI-PACTA / workflow.factset

Other
0 stars 0 forks source link

ci/51 multiple timestamps #53

Closed AlexAxthelm closed 4 months ago

AlexAxthelm commented 4 months ago

Provides mechanism for running multiple instances of workflow.factset (not factset_data_loader) simultaneously, as part of a single deployment. The instances will both pull from the same database, but with different data timestamps or iss reporting dates.

if run with dataTimestamp "20221231,20231231" and issReportingYear 2021,2022, the deploy template will include a container running workflow.factset for each index pair (20221231 with reporting year 2021, and 20231231 with 2022).

Suggest resolving #50 first, since this is a branch of that, though it could be rebased from main without too much difficulty.

I have deployed sucessfully, and am submitting this PR while I wait for results.

github-actions[bot] commented 4 months ago

Docker image from this PR (88833551c20d6dd442db23bc31c8a4e01ffd0e2c) created

docker pull ghcr.io/rmi-pacta/workflow.factset:pr53
AlexAxthelm commented 4 months ago

Converting back to draft:

Running multiple instances of workflow.factset in the same container group leads to all of them terminating with code 137 (out of memory). Will rethink and develop an alternate mechanism.

jdhoffa commented 4 months ago

Please re-request review when you are ready!

AlexAxthelm commented 4 months ago

Closing this, since I think the important functionality was covered in #3