RMI-PACTA / workflow.meta.report.data.creator

3 stars 0 forks source link

Investigate using `write_csv` instead of `write.csv` #13

Open AlexAxthelm opened 1 year ago

AlexAxthelm commented 1 year ago
    I think you're much better off using `readr::write_csv()` here because we can expect to have non-ascii characters in the portfolios we get, and `base::write.csv()` can have very uncertain behavior with that while `readr::write_csv()` has a much more consistent and reliable output (especially regarding file encodings).

_Originally posted by @cjyetman in https://github.com/RMI-PACTA/workflow.meta.report.data.creator/pull/12#discussion_r1054286977_

I think I may have preferred write.csv out of habit for my preference of preferring {base} over {fs} file operations (because of how Azure File Shares handle permissions and timestamps), but this isn't {fs}, so it might still work.