search

RMI-PACTA / workflow.pacta.dashboard

0 stars 0 forks source link

feat: where should the data prep functions live that are specific to the dashboard? #10

Closed MonikaFu closed 2 months ago

MonikaFu commented 2 months ago

From what has been implemented so far, we're using the existing data structures that are generated by pacta.portfolio.report, however, for some plots we will need to generate new datasets because they will be new plots. Where should the functions generating those live? Should we create a new package for them?

Also - at the moment we translate the existing datasets but since for now I assume we will only have the dashboard available in English, I don't think there is a need for translations for the new charts. Do you agree @jdhoffa ?

AlexAxthelm commented 2 months ago

I would say this repo/package is the right spot for those.

MonikaFu commented 2 months ago

@AlexAxthelm thanks! In principle I agree. The only problem I have with this solution is that it violates our intention to not use workflow.-type repos as packages.

AlexAxthelm commented 2 months ago

🤷 All the workflow repos are packages. I think doing some reformatting of data is in-scope here (so long isn't doing the actual analysis).

jdhoffa commented 2 months ago

Agree that at this stage any data preparation functions that are additional to what is required by the report should live in this repository.

We may decide at some point to refactor a utility package out of this to keep track of those function, but for now I think they are fine here

jdhoffa commented 2 months ago

Also agree that at this stage, we do not need translations (although we very likely will at some point!)

jdhoffa commented 2 months ago

Let me know if those answers are sufficient to close this issue

MonikaFu commented 2 months ago

Sufficient, thank you @jdhoffa

MonikaFu commented 2 months ago

Closing this issue given that decision has been made and we have a new issue tracking the creation of the data_prep: #11