search

RMI-PACTA / workflow.pacta.dashboard

0 stars 0 forks source link

feat: build (internal) package infrastructure, and export these two functions #19

Open jdhoffa opened 2 days ago

jdhoffa commented 2 days ago

https://github.com/RMI-PACTA/workflow.pacta.dashboard/blob/e2f02a435db23e4554033154971d94605a966766/main.R#L8-L203

AlexAxthelm commented 5 hours ago

@jdhoffa: the functions are prep_techmix_sector() and prep_exposure_stats()?

is there a reverse dependency I need to track?

jdhoffa commented 5 hours ago

I suppose there are two main things to be aware of. Number 1 is in-scope for this current issue. Number 2 is something to be aware of, but probably a can we can kick down the road for now.

  1. In main.R there are 5 functions that we should package and export:

    • [ ] prep_techmix_sector
    • [ ] prep_exposure_stats
    • [ ] prep_company_bubble
    • [ ] prep_key_bars_company
    • [ ] prep_key_bars_portfolio

  2. We are utilizing un-exported function from various PACTA packages, e.g. pacta.portfolio.report

https://github.com/RMI-PACTA/workflow.pacta.dashboard/blob/32fa4626b59861c26b4b0fef971a6ddeee687998/main.R#L610-L619

jdhoffa commented 5 hours ago

is there a reverse dependency I need to track?

No reverse dependency in terms of function names/ arguments etc.! However of course the final datasets output are fixed, and have an expected format so that must be preserved.