RMI-PACTA / workflow.pacta.report

Other

0 stars 0 forks source link

Refactor/11 convert to package #17

Closed AlexAxthelm closed 3 months ago

AlexAxthelm commented 3 months ago

[X] Working Docker build (local)
[x] Working Docker build (Actions)
[x] Working Test (Actions)
[x] Specify Indices as their own path (don't need rest of pacta-data)
[x] Calling Function as main entry point
[x] R Actions
[x] Major subfunctions
[ ] ~Manifest Export~ #20
[ ] ~Generate Results if needed~ To be done workflow.pacta.webapp
[x] Call JSON Args
[ ] ~Deal with git warnings in create_interactive_report~ Nonblocking, can deal with in that repo.

Closes #11

Depends On https://github.com/RMI-PACTA/pacta.portfolio.report/pull/78

github-actions[bot] commented 3 months ago

Docker build status

commit_time	git_sha	image
2024-06-04T15:29:30Z	e778ffcb4eacbd13cf55d04ffff7538f4f03d578	ghcr.io/rmi-pacta/workflow.pacta.report:pr-17

codecov[bot] commented 3 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

github-actions[bot] commented 3 months ago

Report Links

commit_time	git_sha	config	report	summary	image
2024-06-04T15:29:30Z	e778ffcb4eacbd13cf55d04ffff7538f4f03d578	default_2022Q4	Report	Summary	`ghcr.io/rmi-pacta/workflow.pacta.report:pr-17`
2024-06-04T15:29:30Z	e778ffcb4eacbd13cf55d04ffff7538f4f03d578	default_2023Q4	Report	Summary	`ghcr.io/rmi-pacta/workflow.pacta.report:pr-17`

AlexAxthelm commented 3 months ago

@cjyetman @jdhoffa This is the very coarse refactoring into a package, and accepting the JSON params, in a similar format to workflow.pacta.

I'm definitely not calling it complete, but it is working (if we ignore the known issues in the actual report)

AlexAxthelm commented 3 months ago

Closing since something is messed up with the approvals, will reopen