Closed AlexAxthelm closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.31%. Comparing base (
e6af733
) to head (2a4bb7a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Docker image from this PR (2a4bb7a319ad9af650dbfbd0e116b867dc43327a) created
docker pull ghcr.io/rmi-pacta/workflow.portfolio.parsing:pr25
@cjyetman any idea why the tests for column types are failing on R < 4.0
?
@cjyetman any idea why the tests for column types are failing on
R < 4.0
?
I have no idea what is even being tested here, but.... if I had to take a wild guess on why stuff like this is popping up
file_contents[["currency"]] has type 'integer', not 'character'.
I'd guess that maybe some data.frames are being created with stringsAsFactors = TRUE
because the default changed to stringsAsFactors = FALSE
in R v4.0?!?
Thanks @cjyetman that cleared it up perfectly!
Fixing a bunch of red bubbles that popped up now that we've made
RMI-PACTA/actions
's R suite more robust.biggest changes here are in the testing suite, which maintains the original logic, but has had a major refactor in invocation. One notable addition there is the
expect_multiple_conditions()
(in a helper file), which allows for checking multiplewarning
,error
, ormessage
s pretty smoothly