cjyetman
commented
1 year ago according to the pak::pkg_install() documentation:
- if
ask = FALSE(default in non-interactive session), it will not "ask for confirmation when installing a different version of a package that is already installed", implying that it will install whatever version it is asked to install (in this case, from the local git clone) over top of any previously installed version - if
upgrade = FALSE(default), "It will only upgrade dependent packages ifpkg, or one of their dependencies explicitly require a higher version than what you currently have"
So it seems that the order of installation does not matter because in either case we should end up with the {pacta.portfolio.import} version intended, because either...
- {pacta.portfolio.import} is installed first, and when {pacta.portfolio.analysis} is installed {pacta.portfolio.import} will not be upgraded (unless {pacta.portfolio.analysis} explicitly requires a higher version, in which case we probably need to do that anyway)
- when {pacta.portfolio.analysis} is installed a version of {pacta.portfolio.import} will be installed from GitHub, but then when {pacta.portfolio.import} is installed after, {pak} will re-install from the local git clone over top of the pre-existing install without asking
@jdhoffa @AlexAxthelm id that how you understand it? do you agree? shall we close this then?
jdhoffa
AlexAxthelm
related #82
Since {pacta.portfolio.import} is a dependency of {pacta.portfolio.analysis}, we should consider if we should change the ordering of package installs in the Dockerfile because the install of {pacta.portfolio.analysis} will cause an install of {pacta.portfolio.import} directly from GitHub rather than installing from the clone of the repo copied in, which could lead to version conflicts if we were intending to install a specific, non-main version of {pacta.portfolio.import}.