search

RMI-PACTA / workflow.transition.monitor

This repository is used to create the docker image that runs the transition monitor platform.
Other
2 stars 0 forks source link

Check if every dataset in `web_tool_script_3.R` actually needs `investor_name` and `portfolio_name` #173

Open jdhoffa opened 1 year ago

jdhoffa commented 1 year ago

And remove the call to add_inv_and_port_names_if_needed() if possible.

e.g. https://github.com/RMI-PACTA/workflow.transition.monitor/blob/5430221e8346e2bb8fe0e5149e5799c1f7c18b8d/web_tool_script_3.R#L124

cjyetman commented 7 months ago

I think this would depend on https://github.com/RMI-PACTA/pacta.interactive.report/issues/199 being fixed/implemented, but good to have an issue to track this potential change in the future

jdhoffa commented 7 months ago

The repository that you link has been archived?

If that issue is important, maybe we should transfer it to wherever it should live?

jdhoffa commented 7 months ago

Ah never mind, here it is: https://github.com/RMI-PACTA/pacta.portfolio.report/issues/34

(cant transfer private issues to a public repo)