search

RMI-PACTA / workflow.transition.monitor

This repository is used to create the docker image that runs the transition monitor platform.
Other
2 stars 0 forks source link

Remove unneeded build args #313

Closed AlexAxthelm closed 4 months ago

AlexAxthelm commented 4 months ago

Removes uneeded build args from Dockerfile.

The build args are holdovers from before we used pak to manage and install dependencies, but pak allows us to specify non-main branches in the Remotes: of DESCRIPTION, meaning that the docker image is dependent upon what is committed in code, rather than arguments passed tot he process at build time.

As an example of how to use a non-main (technically, non-default GH branch) dependency:

we might change this example DESCRIPTION:

Imports: 
    config,
    dplyr,
    pacta.executive.summary, 
    pacta.portfolio.allocate,  
    rmarkdown, 
    shiny
Remotes: 
    RMI-PACTA/pacta.executive.summary, 
    RMI-PACTA/pacta.portfolio.allocate,

to read as:

Imports: 
    config,
    dplyr,
    pacta.executive.summary, 
    pacta.portfolio.allocate,  
    rmarkdown, 
    shiny
Remotes: 
    RMI-PACTA/pacta.executive.summary@some-new-branch, 
    RMI-PACTA/pacta.portfolio.allocate,

which would use some-new-branch as the ref for pacta.executive.summary, but still use the default branch for pacta.portfolio.allocate

See also: https://pak.r-lib.org/reference/pak_package_sources.html#github-packages-github-

github-actions[bot] commented 4 months ago

Docker build status

Commit time Git sha Project code Holdings date Language Peer group Report Image
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, GENERAL 2022Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20240515T171342Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, GENERAL 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20240515T171340Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 DE asset_manager Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 DE civil_society Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 DE other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 DE pension_fund Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 DE politician Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 DE researcher Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 EN asset_manager Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 EN civil_society Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 EN pension_fund Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 EN politician Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 EN researcher Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 FR asset_manager Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 FR civil_society Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 FR other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 FR pension_fund Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 FR politician Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08, PA2024CH 2023Q4 FR researcher Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z
2024-05-15T17:07:46Z acf272011af271037074cc9c3f408b575a882a08 ghcr.io/rmi-pacta/workflow.transition.monitor:pr313
History | Commit time | Git sha | Project code | Holdings date | Language | Peer group | Report | Image | | :------------------- | :---------------------------------------- | :----------- | :------------ | :------- | :------------ | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | :-------------------------------------------------------------------------------------- | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | GENERAL | 2022Q4 | EN | other | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2022q4_general-20240515T171342Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2022q4_general/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20240515T171342Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | GENERAL | 2023Q4 | EN | other | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_general-20240515T171340Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_general/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20240515T171340Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | DE | asset_manager | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/asset_manager/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | DE | civil_society | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/civil_society/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | DE | other | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | DE | pension_fund | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/pension_fund/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | DE | politician | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/politician/2/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | DE | researcher | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/researcher/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | EN | asset_manager | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/asset_manager/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | EN | civil_society | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/civil_society/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | EN | other | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | EN | pension_fund | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/pension_fund/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | EN | politician | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/politician/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | EN | researcher | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/researcher/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | FR | asset_manager | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/asset_manager/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | FR | civil_society | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/civil_society/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | FR | other | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/other/2/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | FR | pension_fund | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/pension_fund/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | FR | politician | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/politician/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08, | PA2024CH | 2023Q4 | FR | researcher | [Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/researcher/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html) | `transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z` | | 2024-05-15T17:07:46Z | acf272011af271037074cc9c3f408b575a882a08 | | | | | | ghcr.io/rmi-pacta/workflow.transition.monitor:pr313 |
History JSON`[{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"GENERAL","holdings_date":"2022Q4","language":"EN","peer_group":"other","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2022q4_general-20240515T171342Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2022q4_general/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20240515T171342Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"GENERAL","holdings_date":"2023Q4","language":"EN","peer_group":"other","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_general-20240515T171340Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_general/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20240515T171340Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"DE","peer_group":"asset_manager","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/asset_manager/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"DE","peer_group":"civil_society","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/civil_society/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"DE","peer_group":"other","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"DE","peer_group":"pension_fund","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/pension_fund/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"DE","peer_group":"politician","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/politician/2/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"DE","peer_group":"researcher","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/DE/researcher/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"EN","peer_group":"asset_manager","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/asset_manager/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"EN","peer_group":"civil_society","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/civil_society/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"EN","peer_group":"other","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/other/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"EN","peer_group":"pension_fund","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/pension_fund/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"EN","peer_group":"politician","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/politician/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"EN","peer_group":"researcher","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/EN/researcher/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"FR","peer_group":"asset_manager","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/asset_manager/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"FR","peer_group":"civil_society","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/civil_society/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"FR","peer_group":"other","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/other/2/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"FR","peer_group":"pension_fund","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/pension_fund/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"FR","peer_group":"politician","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/politician/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08,","project_code":"PA2024CH","holdings_date":"2023Q4","language":"FR","peer_group":"researcher","report":"[Report](https://pactadatadev.blob.core.windows.net/ghactions-workflow-transition-monitor-results-reports/rmi_pacta_2023q4_pa2024ch-20240515T171341Z/FR/researcher/1/working_dir/50_Outputs/rmi_pacta_2023q4_pa2024ch/report/index.html)","image":"`transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20240515T171341Z`"},{"commit_time":"2024-05-15T17:07:46Z","git_sha":"acf272011af271037074cc9c3f408b575a882a08","image":"ghcr.io/rmi-pacta/workflow.transition.monitor:pr313"}]`
cjyetman commented 4 months ago

Actually, those build args were added when I added the {pak} installation in #199, and they should work now unless something broke and I didn't realize.

I'm not totally opposed to this change, but the difference is:

Is that desired or at least understood?

AlexAxthelm commented 4 months ago

Actually, those build args were added when I added the {pak} installation in #199, and they should work now unless something broke and I didn't realize.

I'm not totally opposed to this change, but the difference is:

  • in the current state, one can build the Docker image from main using alternate versions of our packages by specifying the specific sha/branch/tag desired in the CLI docker build command
  • after this PR, one will not be able to build a Docker image from a clean version of main, they will have to create a PR branch with a modified Dockerfile (or use main with a modified Dockerfile)

Is that desired or at least understood?

what you have here is an accurate description of the situation after this PR.

I think it's preferable to be able to connect a given docker build to the codebase that it connects to, rather than the build args that were passed in.

Additionally, this makes it easier to integrate updated dependencies (the pacta.* packages) on development branches here, and have the CI pipeline pick them up.