search

RMLio / rmlmapper-java

The RMLMapper executes RML rules to generate high quality Linked Data from multiple originally (semi-)structured data sources
http://rml.io
MIT License
144 stars 61 forks source link

Exit Status 0 When Providing Invalid Serialization Format #194

Closed tobiasschweizer closed 1 year ago

tobiasschweizer commented 1 year ago

Hi there,

I noticed that RMLMapper returns an exit status 0 when called with an invalid serialization format option.

java -jar rmlmapper-6.1.2-r366-all.jar -m mapping.ttl -s turtl

18:55:12.416 [main] ERROR be.ugent.rml.cli.Main .writeOutputUncompressed(607) - Writing output failed. Reason: Serialization turtl not supported

echo $?
0

I noticed that providing an invalid name for the mapping returns an exit status 1 instead. It would be great if this could be made consistent because I am calling the JAR from within another process and check for non 0 exit status for error handling.

tobiasschweizer commented 1 year ago

@DylanVanAssche Can I close this (https://github.com/RMLio/rmlmapper-java/releases/tag/v6.1.3)?

DylanVanAssche commented 1 year ago

Oh yes, of course!