search

RMLio / yarrrml-parser

A YARRRML parser library and CLI in Javascript
MIT License
41 stars 17 forks source link

fix: more instances of RML fetched namespace #196

Closed redmer closed 1 year ago

redmer commented 1 year ago

After another CI fail where no TriplesMaps were found, I navigated through the code and saw that prefix.cc redefined rml:.

https://github.com/RMLio/yarrrml-parser/commit/19aeab289b7580373c3b63bd017e97c5ec7a41c5 already fixed this in bin/parser.js; but as I was using lib/rml-generator.js, I created this PR to manually add the right rml namespace for all files where namespaces.rml was used.

Fixes #195.

bjdmeest commented 1 year ago

@redmer thanks for this! Our developments crossed each other as in v1.5.1 we fixed this issue, together with (a part of) #197, see https://github.com/RMLio/yarrrml-parser/blob/development/lib/namespaces.js .

Could you check which part of #197 still makes sense, so we can focus our next part? I'm closing this one since it got superseded. Thanks a lot for the PR though!