search

RMichelsen / Nvy

Nvy - A Neovim client in C++
MIT License
332 stars 28 forks source link

Nvy does not open file with space in path properly #129

Closed R00dRallec closed 1 month ago

R00dRallec commented 2 months ago

When opening a file with a space in the path (e.g. in the folder name), the file is not opened properly. Instead two 'new' files are opened, see screenshots below.

The issue occurs with Nvy 0.4.0. The issue occurs with Nvy 0.4.0 without config (-u NONE) The issue does not occur with Nvy 0.3.9. The issue does not occur when using nvim (0.10.1) directly from the console.

Console image nvim "C:\Users\user\test folder\test.txt"

Nvy 0.3.9 image Nvy_039.exe "C:\Users\user\test folder\test.txt"

Nvy 0.4.0 image image

Nvy.exe "C:\Users\user\test folder\test.txt"

Nvy 0.4.0 -u NONE image Nvy.exe -u NONE "C:\Users\user\test folder\test.txt"

R00dRallec commented 2 months ago

Issue reproducible with Nvy Release 0.4.0. Cannot reproduce when building cfcea51 locally.

RMichelsen commented 1 month ago

Fixed by #131 in Nvy 0.4.1

ueffel commented 1 month ago

It's still not fixed with the asset https://github.com/RMichelsen/Nvy/releases/download/v0.4.1/Nvy.exe in the v0.4.1 release. This asset has ProductVersion: 0.4.0.2-g3e04fc8 if the 3e04fc8 is the commit hash, it is one commit behind the commit tagged with v0.4.1 Can you please check if you provided the correct asset in the release?

RMichelsen commented 1 month ago

You're right, I messed up the compilation. It should work now!

ueffel commented 1 month ago

It does work now. Thanks.