search

RNA-FRETools / MASH-FRET

MATLAB package to analyze single-molecule FRET data
https://rna-fretools.github.io/MASH-FRET/
GNU General Public License v3.0
8 stars 2 forks source link

MASH- FRET does not calculate traces over the whole channel pictures #134

Closed Much756 closed 5 months ago

Much756 commented 5 months ago

Hi,

I am just getting started with MASH-FRET (v.1.3.4) and came across the issue, when I was checking my traces in the tracemanager. Apparently traces were only calculated for around 2/3 of the detected spots along the x- dimension of the two channels.

Screenshot 2024-05-17 110748

I think, I was able to track down the error to create_trace.m file line 20, where the dimensions of the resolutions were falsely assigned. But I do not know, if this is intended or if I did something wrong while iterating through the calculation steps.

Best regards, Michael Kaltenegger

e-mail: michael.kaltenegger@uni-graz.at

mca-sh commented 5 months ago

Hello Michael and thank you for the report.

Yes indeed your are right, the bug comes from the wrong assignment of video dimensions at the exact code line you mentioned. We are not used to video having width unequal to height, so thank you very much for detecting (and fixing!) the bug.

You can find the corrected version here: https://github.com/RNA-FRETools/MASH-FRET/archive/refs/heads/master.zip or just by git pull in your git repository.

Best, Mélodie