RNAcentral / rnacentral-import-pipeline

RNAcentral data import pipeline
Apache License 2.0
2 stars 1 forks source link

Pylint alerts corrections as part of an intervention experiment 1853 #208

Closed evidencebp closed 4 days ago

evidencebp commented 1 week ago

Makes the interventions describe in intervention issue. The experiment is described here.

Each intervention was done in a dedicated commit with a message explaining it.

As we discussed, I created first a PR with the minor simple alerts:mline-too-long, unnecessary-pass, and broad-exception-caught. I hope that the review will be easy.

blakesweeney commented 4 days ago

' Hi,

Thanks for your contribution to RNAcentral. I'\''ve take a look over the changes and I think they are fine. I'\''m a little worried about the formatting changes. Generally we use black to format things, which may end up conflicting with these changes. I will approve them even if they later get changed again. I think pylint also formatted some comments and docstrings which would also be useful.

The exception handling also seems fine, so we can go ahead with this change.'

evidencebp commented 4 days ago

Thanks!