search

RNAcentral / rnacentral-webcode

RNAcentral website source code
https://rnacentral.org
Apache License 2.0
32 stars 9 forks source link

Shall we ask EBI search to change labels on 'has_conserved_structure', 'has_go_annotations', 'qc_warnings_found' and 'qc_warning found'? #457

Closed BurkovBA closed 5 years ago

BurkovBA commented 5 years ago

Currently we're explicitly renaming labels of the following facets on the frontend:

[ 'has_conserved_structure', 'has_go_annotations', 'qc_warnings_found', 'qc_warning found' ]

https://github.com/RNAcentral/rnacentral-webcode/blob/53bfda79b5be8976499a07a1226823fcfffc60c3/rnacentral/portal/static/js/components/text-search/text-search.service.js#L324

I don't want to duplicate this codebase in sequence search and text search.

Maybe we should stick with these new labels everywhere?

AntonPetrov commented 5 years ago

I would prefer to have the ability to rename the facets in front end because we had to rename them quite a few times in the past year and it would be unreasonable to have to email www-prod each time and wait for hours/days until the changes are applied.

Le mer. 10 avr. 2019 à 17:23, Boris Burkov notifications@github.com a écrit :

Assigned #457 https://github.com/RNAcentral/rnacentral-webcode/issues/457 to @AntonPetrov https://github.com/AntonPetrov.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/RNAcentral/rnacentral-webcode/issues/457#event-2266656844, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaaI9skCfPCbKoe34LhpLBPqcfRliItks5vfg_mgaJpZM4cnvl2 .

BurkovBA commented 5 years ago

Agree, we shall keep this whole function for future last-minute renames.

But if we decided to change the names of some labels, doesn't it make sense to actually change their names in our index?

Cause this list can grow on and on, what's the point of expanding it indefinitely and repeating the labels everywhere?