Closed carlosribas closed 5 years ago
Looks great, thanks Carlos! 🚀
Here is some feedback:
The API returns None for sequences that do not have a layout: http://localhost:9000/api/v1/rna/URS000019E0CD/2d/svg Should it return something more restful, maybe a 404 code?
None
I would change rna-svg-species-specific to rna-2d-svg because this endpoint is not species-specific
rna-svg-species-specific
rna-2d-svg
Code changed as suggested.
carlosribas
commented
5 years ago carlosribas
commented
5 years ago
Looks great, thanks Carlos! 🚀
Here is some feedback:
The API returns
Nonefor sequences that do not have a layout: http://localhost:9000/api/v1/rna/URS000019E0CD/2d/svg Should it return something more restful, maybe a 404 code?I would change
rna-svg-species-specifictorna-2d-svgbecause this endpoint is not species-specific