RNCan / BioSimClient_R

An R client for the BioSIM Web API
2 stars 1 forks source link

1991_2020 normals not working #2

Closed LeofkJ closed 1 year ago

LeofkJ commented 1 year ago

Hi! Running:

> locations <- BioSIM::twoLocationsInSouthernQuebec

> normals <- BioSIM::getNormals("1991_2020", locations$KeyID, locations$Latitude, locations$Longitude, averageOverTheseMonths = NULL)

results in this error:

  biosimclient.BioSimServerException: Code 500: Internal Server Error. Something went Wrong!  
Details : The given key '1991_2020' was not present in the dictionary.
biosimclient.BioSimClient.getStringFromConnection(BioSimClient.java:130)
biosimclient.BioSimClient.internalCalculationForNormals(BioSimClient.java:189)
biosimclient.BioSimClient.getNormals(BioSimClient.java:258)
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.base/java.lang.reflect.Method.invoke(Method.java:564)
j4r.lang.codetranslator.REnvironment.processMethod(REnvironment.java:510)
j4r.lang.codetranslator.REnvironment.processCode(REnvironment.java:232)
j4r.net.server.JavaGatewayServer$JavaGatewayClientThread.processRequest(JavaGatewayServer.java:177)`

Doing the same but with 1971_2000, 1981_2010 and 2001_2030 works as expected

donenrique24 commented 1 year ago

Thanks for raising this issue.

The normals for the 1991-2020 period have just been made available for BioSIM this year. Normally, the API should have returned the predicted 1991-2020 as per the RCM4 (which are a bit outdated).

Anyway, I have been working on the integration of these observed normals for 1991-2020 and the deployment is planned this weekend. If everything goes well, this bug should be fixed by Monday morning. I'll close this issue when it's done so that you get the notification.

Regards

donenrique24 commented 1 year ago

The Web API has been upgraded to version 1.0.7. Observed normals for the 1991-2020 period are now available.

LeofkJ commented 1 year ago

Thank you!