RNO-G / librno-g

DAQ I/O and hardware access libraries for RNO-G
GNU General Public License v3.0
0 stars 1 forks source link

Updates for the Phased Array Trigger #9

Open ryankrebs016 opened 2 months ago

ryankrebs016 commented 2 months ago

Changes for the upcoming phased trigger on the FLOWER. Needs the simultaneous changes from rno-g-ice-software and mattak to be used on the daq.

Note: I may have broken firmware back compatibility by not including version checks, @cozzyd let me know if I need these.

cozzyd commented 2 months ago

I took a first pass at this. I haven't reviewed the scaler stuff yet though. It looks like there have been a lot of changes there including rearranging some things?

cozzyd commented 1 month ago

Trying to rebase this to master now. If it's true that the coinc trigger and phased trigger can't be simultaneously on, we should change the configure_trigger API to take a union of the two or something, right?

ryankrebs016 commented 1 month ago

The triggers can run simultaneously. The outputs are or’ed together so we can. Though I don’t know of a situation where both would need to be running

cozzyd commented 1 month ago

ah ok I misunderstood you today! That's good to know!