search

RNO-G / mattak

RNO-G dataformats
1 stars 1 forks source link

Add trigger threshold info to EventInfo. Propag… #14

Closed fschlueter closed 1 year ago

fschlueter commented 1 year ago

…ate verbose to Dataset

fschlueter commented 1 year ago

I will have a look tmr for the uproot thing

cozzyd commented 1 year ago

So one question is if we want to always load this with EventInfo, or only on demand (perhaps having an analogous thing to EventInfo called DAQInfo). Especially with uproot, there may be some overhead to loading it as it's in a different file and you have to find it. I guess it can also just be a flag though (and it would be None otherwise!)

fschlueter commented 1 year ago

Hm, I think it would keep things easier storing everything in one class. When this class gets to packed/full that is bad as well but I do not see that issue atm. Regarding a flag, sure that can be done but I wonder if it is necessary, should be super fast to read the daqstatus.root file, no?

fschlueter commented 1 year ago

Alright, @cozzyd have a look :)

cozzyd commented 1 year ago

i don't see any obvious problems! and thanks for the cleanups. have you tested that it works with both backends and with both combined and not combined files? if so... go ahead and merge!

fschlueter commented 1 year ago

Yes I did!