search

RNO-G / mattak

RNO-G dataformats
1 stars 1 forks source link

Implement voltage calibration in python backends #24

Closed fschlueter closed 7 months ago

fschlueter commented 11 months ago

@cozzyd, it seems like implementing the voltage calibration for the uproot backend is more complicated? One have to reimplement the calculation in python code?

cozzyd commented 10 months ago

Yeah, this is pretty straightforward for the PyROOT backend, but for the uproot backend it requires a bit more work. The goal was to separately compile the meat of the algorithm with pybind11 so that the uproot backend can work without reimplementing anything (just has to read in the data and pass it in correctly), but this hasn't been implemented yet. I'll take a look at this again since it has been a while...

fschlueter commented 8 months ago

@CamphynR thanks for doing this! I left a few comments. Some of them are really picky, in general I think this is good work!

fschlueter commented 8 months ago

Okay, now we got some nasty merge conflict. I will try to fix those

fschlueter commented 7 months ago

This will be a nightmare to merge...

fschlueter commented 7 months ago

@cozzyd can you please review this PR? I set the option Hide whitespace changes, in case you wondered. If that setting is only active for me I recommend setting it (reduces the diff by A LOT.