search

RNO-G / mattak

RNO-G dataformats
1 stars 1 forks source link

Optimize voltage calibration #40

Closed fschlueter closed 4 months ago

fschlueter commented 4 months ago

This PR is passed on #38

fschlueter commented 4 months ago

@cozzyd and @CamphynR if you want to have a look. This speeds up the uproot calibration by quite a bit. It also allows to use the same calibration function to either use the calibration constants + residuals or the full bias scan data.

fschlueter commented 4 months ago

Just to give some numbers how fast the calibration is right now. For pyroot it is around 0.065 s per event while for uproot it is 0.07. Certainly pyroot can be made faster when adopting a similar strategy as for uproot. However, without calibration speed for both backends is ~ 100 faster

fschlueter commented 4 months ago

@cozzyd wanna review or can I merge?

fschlueter commented 4 months ago

I will go ahead since the tests pass