search

RNO-G / mattak

RNO-G dataformats
1 stars 1 forks source link

Add option to not read waveforms #64

Open fschlueter opened 1 month ago

fschlueter commented 1 month ago

Addresses issue #63. @cozzyd I am not sure anymore how useful this is. One could say "but it will also not harm" but I see two issues:

What do you think.

BTW: The use case is to read runs for which one does not need to download the waveforms (for the station directly for example) to plot trigger rates and so on.

cozzyd commented 1 month ago

This is very similar to the skip incomplete option. I think it should just be the default behavior when only a header file is present. Implementation in pyroot backend should be nearly identical to skip incomplete?

sjoerd-bouma commented 1 month ago

I thought this should already work with skip_incomplete set to False, which currently still works on the uproot backend but broke on the pyroot backend with #54. (See also #61 ). It turns out you still need a combined.root file in that case, but I already used this to extract trigger rates from the header files. So maybe rather than adding an extra option skip_incomplete should also handle the case where no combined.root file is present at all?

We should probably add a test for the skip_incomplete case in any case, seeing as it has broken already.