RNourshargh / CavitySim

This Matlab code simulates different optical cavities using ABCD matricies from the constituent optical components.
MIT License
0 stars 0 forks source link

Add reader for scope data #9

Closed znicholls closed 4 years ago

RNourshargh commented 4 years ago

Codecov Report

Merging #9 into master will decrease coverage by 4.31%. The diff coverage is 82.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   96.35%   92.03%   -4.32%     
==========================================
  Files           2        3       +1     
  Lines         137      201      +64     
  Branches       11       16       +5     
==========================================
+ Hits          132      185      +53     
- Misses          5       15      +10     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/cavitysim/io.py 82.81% <82.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd2e185...8f7695a. Read the comment docs.

RNourshargh commented 4 years ago

The lines the tests are not hitting all appear to be exceptions which should never be encountered with a real set of data. I think I understand most of what is in this. I'd appreciate a quick chat to clarify some of the subtleties. I really appreciate your help.

RNourshargh commented 4 years ago

Apologies for accidentally closing it. I am still figuring this thing out.