[ros2] Enabling math constants for Windows.

ROBOTIS-GIT / hls_lfcd_lds_driver

ROS package for HLDS HLS-LFCD LDS driver

http://turtlebot3.robotis.com

BSD 3-Clause "New" or "Revised" License

88 stars 70 forks source link

[ros2] Enabling math constants for Windows. #47

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

A fix to unblock Windows build.

Define _USE_MATH_DEFINES to enable math constants usage. https://docs.microsoft.com/en-us/cpp/c-runtime-library/math-constants

seanyen commented 4 years ago

@ROBOTIS-zerom @robotpilot This is ready for review and merge. Hope this can be cherry-picked to all ROS 2 branches.

seanyen commented 4 years ago

@ROBOTIS-Will Sorry to spam again. I am currently curating another tutorial that documents how to do this on Windows, and in order to make the experience neat, especially when a developer checkouts and builds the TurtleBot 3 code, it would be great that this one and https://github.com/ROBOTIS-GIT/DynamixelSDK/pull/390 can be resolved by the upstream. Let me know what you think. Thanks!

ROBOTIS-Will commented 4 years ago

@seanyen Sorry for the super delayed response. DYNAMIXEL SDK is maintained from other department but I'll request them to review your change. Thank you!