search

ROBOTIS-GIT / hls_lfcd_lds_driver

ROS package for HLDS HLS-LFCD LDS driver
http://turtlebot3.robotis.com
BSD 3-Clause "New" or "Revised" License
90 stars 70 forks source link

Release for ROS 2 rolling! #61

Open emersonknapp opened 3 years ago

emersonknapp commented 3 years ago

Hello! I use one of these lidars on a custom robot rig and would love to have the driver released into ROS 2 Rolling so I don't have to necessarily build from source.

ROBOTIS-Will commented 3 years ago

@emersonknapp Sorry about the delayed response. I'll create a rolling branch and release for ROS2, but this branch will be a duplicated copy of ros2-devel. Thanks!

ROBOTIS-Will commented 3 years ago

https://github.com/ros/rosdistro/pull/29182

emersonknapp commented 3 years ago

I'll create a rolling branch

In my packages - I just release into Rolling distro using the master branch - so you could just specify ros2-devel to bloom if you want, most packages do not have a separate rolling branch.

ROBOTIS-Will commented 3 years ago

@emersonknapp Using the master branch as a rolling release sounds better. Thanks for the tip! :)

tdenewiler commented 3 years ago

I see that there is a release for the Rolling distro.

http://repo.ros2.org/status_page/ros_rolling_default.html?q=lfcd

Any chance you can do the same for the Galactic distro? Hopefully you can use the same branch for all 3 distros.

ROBOTIS-Will commented 3 years ago

@tdenewiler Sure! https://github.com/ros/rosdistro/pull/30220

goekce commented 2 years ago

@emersonknapp Using the master branch as a rolling release sounds better. Thanks for the tip! :)

@ROBOTIS-Will I am building packages for rolling. Should I use rolling-devel instead of the similar branches ros2 and ros2-devel? rolling-devel seems to be 2 commits ahead of ros2 branch.

I am a bit confused. In https://github.com/ROBOTIS-GIT/turtlebot3 and other repos like turtlebot3{,_msgs} and DynamixelSDK ros2 branch seems to be the rolling version. Is there a guideline which branch is released to rolling?

ROBOTIS-Will commented 2 years ago

Hi @goekce I'm sorry about the confusion. Like other repositories, the ros2 branch will be released to rolling. I'll fix the debian package in the next release. Thanks!