Setting the Client_Key of MicroXRCE-Agent

ROBOTIS-GIT / ros2arduino

This library helps the Arduino board communicate with the ROS2 using XRCE-DDS.

Apache License 2.0

216 stars 43 forks source link

Closed taro83 closed 5 years ago

taro83 commented 5 years ago

Added an argument in Node() that can set Client Key of Micro XRCE-Agent at node initialization

OpusK commented 5 years ago

Hi, @taro83

Thank you for your contribution. I'm just leaving a few reviews, can you fix it?

OpusK commented 5 years ago

Please delete the files below and add them to .gitignore if necessary.

taro83 commented 5 years ago

Hi @OpusK Thank you for your comment. I added setting to ignore .DS_Store.

I will try to fix any other suggestions from you.

OpusK commented 5 years ago

@taro83

You added .gitignore but didn't delete the DS_Store files. Please delete it.

taro83 commented 5 years ago

@OpusK Sorry, my mistake. I deleted DS_Store files.

OpusK commented 5 years ago

@taro83

Thanks for your contribution. We will release this soon.

taro83 commented 5 years ago

Thank you for merge ! I will follow this good project.