ROBOTIS-GIT / turtlebot3_machine_learning

Apache License 2.0
119 stars 82 forks source link

Detection of minimal Lidar distacne value is updated on total four stage #22

Closed hyunsooda closed 4 years ago

hyunsooda commented 5 years ago

See issue #19 for detail.

kijongGil commented 5 years ago

@hyunsooda Thanks for your contribution. Now I'm busy with other project. I will soon test and merge your PR. Thanks! Gilbert.

JaehyunShim commented 4 years ago

@hyunsooda

I read the conversation between you and @kijongGil, and I don't get your point. The radius of the burger model is approximately 0.070[m] and I don't see any problems on setting min_range to 0.130[m]. I think @kijongGil just used 0.130[m] as a small enough value, but there is no specific meaning in it other than it should be bigger than the radius. Ryan

JaehyunShim commented 4 years ago

As there have been no updates, I am closing this pr.