search

ROBOTIS-GIT / turtlebot3_machine_learning

Apache License 2.0
123 stars 82 forks source link

Logging #47

Closed luwi1993 closed 4 years ago

ROBOTIS-Will commented 4 years ago

@luwi1993 Thank you for your contribution. We'll merge this into a temporary branch for the internal review and updating the eManual, then merged into the master branch. This process may take some time due to other development schedules.

luwi1993 commented 4 years ago

Hello ROBOTIS Team,

please remove the db_config dictionary from turtlebot3_dqn/nodes/utils/log_utils.py this should be passed by a config.json our version works in a docker container on different systems so i had to put the configuration there like this

looking forward to future contributions,

Greetings, Lukas Widowski

Am Mi., 9. Sept. 2020 um 10:46 Uhr schrieb Will Son < notifications@github.com>:

Merged #47 https://github.com/ROBOTIS-GIT/turtlebot3_machine_learning/pull/47 into feature-update-master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ROBOTIS-GIT/turtlebot3_machine_learning/pull/47#event-3744688419, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALUSATFTLQOA55AF7QQSZN3SE46GRANCNFSM4QYH6ZIA .

ROBOTIS-Will commented 4 years ago

@luwi1993 Thank you for the heads up. Hope you and your team are safe from the Covid-19.