env-hooks in ros2 branches

ROBOTIS-GIT / turtlebot3_simulations

Simulations for TurtleBot3

http://turtlebot3.robotis.com/

Apache License 2.0

309 stars 427 forks source link

env-hooks in ros2 branches #123

Closed joe28965 closed 3 years ago

joe28965 commented 3 years ago

I was curious why no env hooks are used in any of the ros2 branches. This will eliminate the need for people to manually add the GAZEBO_MODEL_PATH to their bashrc

echo 'export GAZEBO_MODEL_PATH=$GAZEBO_MODEL_PATH:~/turtlebot3_ws/src/turtlebot3/turtlebot3_simulations/turtlebot3_gazebo/models' >> ~/.bashrc

Is there a specific reason as to why it's preferred to do this manually?

ROBOTIS-Ashe commented 3 years ago

@joe28965

Hi. @joe28965 We will discuss it in the team and update our package. Thank you so much for your contribution.

Rayman commented 3 years ago

@joe28965 I've created a PR with a much cleaner way here: https://github.com/ROBOTIS-GIT/turtlebot3_simulations/pull/129. I hope you can take a look if it solves your problem.

ROBOTIS-Will commented 3 years ago

This fix had been merged and released in the recent ROS2 update. https://github.com/ros/rosdistro/pull/28006 Thank you @Rayman , @joe28965 for your contributions!