ROBOTIS-GIT / turtlebot3_simulations

Simulations for TurtleBot3
http://turtlebot3.robotis.com/
Apache License 2.0
329 stars 434 forks source link

Add "--ros-args -r" arguments for Eloquent #91

Closed mkhansenbot closed 4 years ago

mkhansenbot commented 5 years ago

The tb3 model files will need updating for eloquent to add the "--ros-args -r" to the arguments list.

See issue here: ros-simulation/gazebo_ros_pkgs#991

routiful commented 5 years ago

@mkhansen-intel I've tested this repo with Dashing patch 3 and every topic are shown correctly.

/clock
/cmd_vel
/imu
/joint_states
/odom
/parameter_events
/robot_description
/rosout
/scan
/tf
/tf_static

I think this updates doesn't need to yet. But for next version of ROS 2, I will make another branch to support this issue.

mkhansenbot commented 5 years ago

Correct, this is not needed for Dashing, but is required for Eloquent. I just wanted you to be aware.

mkhansenbot commented 4 years ago

Any update on this? Are you planning to do an Eloquent release at some point soon?

CleopatraDion commented 4 years ago

Yes, I am also curious if this is going to be done, or what specifically needs to be done?

ROBOTIS-Will commented 4 years ago

Sorry for the delayed update. I know we are all looking for the Foxy at this point, but please let me know if this doesn't work.

mkhansenbot commented 4 years ago

I can't test it but thanks for merging a fix. I'll close this issue. Will there be a Foxy branch created?

ROBOTIS-Will commented 4 years ago

@mkhansenbot Yes, turtlebot3_simulations foxy branch will be created and updated along with turtlebot3 repository. Thank you!