search

ROCKNIX / distribution

Other
314 stars 56 forks source link

standalone emulator start scripts - fix big / little core settings #244

Closed porschemad911 closed 2 months ago

porschemad911 commented 3 months ago

System and game-level big / little core config for standalone emulators were broken. Reason being that PLATFORM and ROMNAME used in the standalone emulator start scripts are undefined, so fix to match other get_setting calls in the scripts.

porschemad911 commented 3 months ago

I have tested system default, platform override and game override for cores setting with this change with dolphin-sa and flycast-sa emulators, all working ok.

sydarn commented 2 months ago

I have tested ppsspp-sa, flycast-sa and dolphin-sa on rk3399. I never checked the core utilization specifically before, but now definitely honors big cores per system level when little is defined as the system settings default.

porschemad911 commented 2 months ago

Thanks for testing also @sydarn, I've been low on time. I tested using taskset -c -p <pid> to make sure the affinity was correct, then htop to verify activity.

porschemad911 commented 2 months ago

Refactored a little to pass PLATFORM to standalone emulator start scripts, then in start scripts parse and use PLATFORM in set_settings call. Need to retest. Also attempting to support core affinity for PortMaster launch scripts.

porschemad911 commented 2 months ago

Latest revision tested with dolphin-sa, flycast-sa (both Dreamcast and Naomi), duckstation-sa, aethersx2, ppsspp-sa and ports. All working ok.

sydarn commented 2 months ago

Awesome, thank you!