ROCKNIX / distribution

Other
376 stars 67 forks source link

Waybar feedback #464

Open sydarn opened 2 months ago

sydarn commented 2 months ago

Some feedback on what I noticed in regards to waybar implementation by @rishooty

porschemad911 commented 2 months ago

Dolphin is rendered off-centre on my Odroid Go Ultra with the S922X-PANFROST build.

The following command fixes it:

# echo $(swaymsg '[pid="12935"] floating disable, fullscreen enable')
[ { "success": true }, { "success": true } ]

However it has to be based on pid, as class, app_id, title etc are not set on the sway window and name is not permitted as a window selection criteria:

{
  "id": 13,
  "type": "floating_con",
  "orientation": "none",
  "percent": 0.74668471896955513,
  "urgent": false,
  "marks": [],
  "focused": true,
  "layout": "none",
  "border": "none",
  "current_border_width": 2,
  "rect": {
    "x": 0,
    "y": 0,
    "width": 639,
    "height": 479
  },
  "deco_rect": {
    "x": 0,
    "y": 0,
    "width": 0,
    "height": 0
  },
  "window_rect": {
    "x": 0,
    "y": 0,
    "width": 639,
    "height": 479
  },
  "geometry": {
    "x": 0,
    "y": 0,
    "width": 640,
    "height": 480
  },
  "name": "Dolphin 5.0 | JITARM64 DC | OpenGL | HLE | GAHEGG",
  "window": null,
  "nodes": [],
  "floating_nodes": [],
  "focus": [],
  "fullscreen_mode": 0,
  "sticky": false,
  "floating": "user_on",
  "scratchpad_state": "none",
  "pid": 12935,
  "app_id": null,
  "visible": true,
  "max_render_time": 0,
  "shell": "xdg_shell",
  "inhibit_idle": false,
  "idle_inhibitors": {
    "user": "none",
    "application": "none"
  }
}
aenertia commented 2 months ago

Is there a possibility to make the hotkey set to the modal/function pin that's available on many (but not all devices) with a long press. On test and latest compile on my rg353m/v - I see it flash up before ES and then it disappears forever (including in games/ra cores), having a reload on hold IME fixes swaybar focus/placement issues on desktop so am thinking will likely work here also..