ROCm / AMDMIGraphX

AMD's graph optimization engine.
https://rocm.docs.amd.com/projects/AMDMIGraphX/en/latest/
MIT License
185 stars 85 forks source link

[impr]: RENAME requirements.txt to rbuild.json #3293

Open yiakwy-xpu-ml-framework-team opened 3 months ago

yiakwy-xpu-ml-framework-team commented 3 months ago

Problem Description

Description

The name of "requirements.txt" is misleading. It is actually an internal rbuild config file (project name , branch name, commit id).

I requested to change the file name to reflect its nature so that python dependencies and C++ project (or super project) dependencies won't be mixed.

Operating System

Ubunu22.04

CPU

AMD EPYC 9534 64-Core Processor

GPU

AMD Instinct MI300

Other

No response

ROCm Version

ROCm 6.0.0

Steps to Reproduce

N/A

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

pfultz2 commented 3 months ago

The requirements.txt is used by cget(which is what rbuild uses) so users can install migraphx with its 3rd-party dependencies automatically.

yiakwy-xpu-ml-framework-team commented 3 months ago

The requirements.txt is used by cget(which is what rbuild uses) so users can install migraphx with its 3rd-party dependencies automatically.

Thank you for instant response @pfultz2. So could we use a better name to reflect this ?

pfultz2 commented 3 months ago

So could we use a better name to do reflect this ?

We could, but cget would need to be updated to support such a name. There is this issue here to support requirments.cget and also this issue here to support requirements.cmake.