ROCm / AMDMIGraphX

AMD's graph optimization engine.
https://rocm.docs.amd.com/projects/AMDMIGraphX/en/latest/
MIT License
185 stars 86 forks source link

Call compile with correct executable #3493

Closed richagadgil closed 1 month ago

richagadgil commented 1 month ago

Fixing Issue #3487 where compiling with incorrect hiprtc function results in error

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.17%. Comparing base (c1f4371) to head (4f35b16). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3493 +/- ## ======================================== Coverage 92.17% 92.17% ======================================== Files 512 512 Lines 21385 21385 ======================================== Hits 19712 19712 Misses 1673 1673 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

migraphx-bot commented 1 month ago
Test Batch Rate new
4f35b1
Rate old
bdbe34
Diff Compare
torchvision-resnet50 64 3,261.08 3,258.84 0.07% :white_check_mark:
torchvision-resnet50_fp16 64 6,997.72 6,981.91 0.23% :white_check_mark:
torchvision-densenet121 32 2,437.15 2,436.52 0.03% :white_check_mark:
torchvision-densenet121_fp16 32 4,077.48 4,070.78 0.16% :white_check_mark:
torchvision-inceptionv3 32 1,638.19 1,640.50 -0.14% :white_check_mark:
torchvision-inceptionv3_fp16 32 2,770.13 2,764.39 0.21% :white_check_mark:
cadene-inceptionv4 16 776.53 777.25 -0.09% :white_check_mark:
cadene-resnext64x4 16 809.46 809.84 -0.05% :white_check_mark:
slim-mobilenet 64 7,535.59 7,537.85 -0.03% :white_check_mark:
slim-nasnetalarge 64 211.83 211.79 0.02% :white_check_mark:
slim-resnet50v2 64 3,506.62 3,504.89 0.05% :white_check_mark:
bert-mrpc-onnx 8 1,149.15 1,152.66 -0.30% :white_check_mark:
bert-mrpc-tf 1 475.66 463.93 2.53% :white_check_mark:
pytorch-examples-wlang-gru 1 427.58 485.39 -11.91% :red_circle:
pytorch-examples-wlang-lstm 1 405.24 384.58 5.37% :high_brightness:
torchvision-resnet50_1 1 776.46 817.62 -5.03% :red_circle:
cadene-dpn92_1 1 435.30 399.06 9.08% :high_brightness:
cadene-resnext101_1 1 383.07 382.30 0.20% :white_check_mark:
onnx-taau-downsample 1 342.77 343.08 -0.09% :white_check_mark:
dlrm-criteoterabyte 1 33.32 33.33 -0.03% :white_check_mark:
dlrm-criteoterabyte_fp16 1 52.72 52.74 -0.04% :white_check_mark:
agentmodel 1 9,197.77 8,377.88 9.79% :high_brightness:
unet_fp16 2 58.97 58.79 0.31% :white_check_mark:
resnet50v1_fp16 1 931.46 937.71 -0.67% :white_check_mark:
resnet50v1_int8 1 963.67 1,041.29 -7.45% :red_circle:
bert_base_cased_fp16 64 1,170.02 1,170.74 -0.06% :white_check_mark:
bert_large_uncased_fp16 32 363.56 363.58 -0.00% :white_check_mark:
bert_large_fp16 1 198.98 199.03 -0.03% :white_check_mark:
distilgpt2_fp16 16 2,204.72 2,199.30 0.25% :white_check_mark:
yolov5s 1 534.50 540.42 -1.10% :white_check_mark:
tinyllama 1 43.45 43.45 0.01% :white_check_mark:
vicuna-fastchat 1 170.71 169.65 0.63% :white_check_mark:
whisper-tiny-encoder 1 418.14 418.63 -0.12% :white_check_mark:
whisper-tiny-decoder 1 426.17 430.21 -0.94% :white_check_mark:

This build is not recommended to merge :red_circle:

migraphx-bot commented 1 month ago


     :white_check_mark: bert-mrpc-onnx: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert-mrpc-tf: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance
     :white_check_mark: torchvision-resnet50_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-dpn92_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-resnext101_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance
     :white_check_mark: agentmodel: PASSED: MIGraphX meets tolerance
     :white_check_mark: unet: PASSED: MIGraphX meets tolerance
     :white_check_mark: resnet50v1: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert_base_cased_fp16: PASSED: MIGraphX meets tolerance
:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

     :white_check_mark: bert_large: PASSED: MIGraphX meets tolerance
     :white_check_mark: yolov5s: PASSED: MIGraphX meets tolerance
     :white_check_mark: tinyllama: PASSED: MIGraphX meets tolerance
     :white_check_mark: vicuna-fastchat: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-encoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-decoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: distilgpt2_fp16: PASSED: MIGraphX meets tolerance