search

ROCm / AMDMIGraphX

AMD's graph optimization engine.
https://rocm.docs.amd.com/projects/AMDMIGraphX/en/latest/
MIT License
185 stars 86 forks source link

Improvements to propagate_const for int4 #3494

Closed pfultz2 closed 1 month ago

TedThemistokleous commented 1 month ago

Fix CI but looks fine code wise.

Kicked off other CI checks for you

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.02%. Comparing base (9fb2f4e) to head (8865c6c). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3494 +/- ## ======================================== Coverage 92.02% 92.02% ======================================== Files 509 509 Lines 21005 21014 +9 ======================================== + Hits 19330 19339 +9 Misses 1675 1675 ``` | [Flag](https://app.codecov.io/gh/ROCm/AMDMIGraphX/pull/3494/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/ROCm/AMDMIGraphX/pull/3494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ROCm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

migraphx-bot commented 1 month ago
Test Batch Rate new
8865c6		 Rate old
e2e921		 Diff Compare
torchvision-resnet50 64 3,258.84 3,255.97 0.09% :white_check_mark:
torchvision-resnet50_fp16 64 6,975.55 6,971.30 0.06% :white_check_mark:
torchvision-densenet121 32 2,432.37 2,431.20 0.05% :white_check_mark:
torchvision-densenet121_fp16 32 4,071.50 4,087.45 -0.39% :white_check_mark:
torchvision-inceptionv3 32 1,638.66 1,635.71 0.18% :white_check_mark:
torchvision-inceptionv3_fp16 32 2,752.88 2,755.82 -0.11% :white_check_mark:
cadene-inceptionv4 16 779.61 780.33 -0.09% :white_check_mark:
cadene-resnext64x4 16 808.09 806.94 0.14% :white_check_mark:
slim-mobilenet 64 7,468.22 7,464.88 0.04% :white_check_mark:
slim-nasnetalarge 64 208.31 208.51 -0.09% :white_check_mark:
slim-resnet50v2 64 3,437.61 3,435.02 0.08% :white_check_mark:
bert-mrpc-onnx 8 1,150.24 1,146.59 0.32% :white_check_mark:
bert-mrpc-tf 1 321.88 318.44 1.08% :white_check_mark:
pytorch-examples-wlang-gru 1 417.31 421.02 -0.88% :white_check_mark:
pytorch-examples-wlang-lstm 1 383.00 374.33 2.32% :white_check_mark:
torchvision-resnet50_1 1 777.65 803.63 -3.23% :red_circle:
cadene-dpn92_1 1 399.56 395.85 0.94% :white_check_mark:
cadene-resnext101_1 1 379.91 379.14 0.20% :white_check_mark:
onnx-taau-downsample 1 366.47 366.52 -0.02% :white_check_mark:
dlrm-criteoterabyte 1 35.06 35.01 0.12% :white_check_mark:
dlrm-criteoterabyte_fp16 1 58.14 58.19 -0.09% :white_check_mark:
agentmodel 1 8,212.14 8,063.61 1.84% :white_check_mark:
unet_fp16 2 58.88 58.95 -0.12% :white_check_mark:
resnet50v1_fp16 1 957.34 950.25 0.75% :white_check_mark:
resnet50v1_int8 1 977.49 971.97 0.57% :white_check_mark:
bert_base_cased_fp16 64 1,170.21 1,170.73 -0.04% :white_check_mark:
bert_large_uncased_fp16 32 363.61 363.46 0.04% :white_check_mark:
bert_large_fp16 1 210.86 213.45 -1.21% :white_check_mark:
distilgpt2_fp16 16 2,202.81 2,199.49 0.15% :white_check_mark:
yolov5s 1 551.17 539.25 2.21% :white_check_mark:
tinyllama 1 43.58 43.47 0.24% :white_check_mark:
vicuna-fastchat 1 170.38 174.86 -2.56% :white_check_mark:
whisper-tiny-encoder 1 420.31 417.66 0.63% :white_check_mark:
whisper-tiny-decoder 1 429.41 427.92 0.35% :white_check_mark:

This build is not recommended to merge :red_circle:

migraphx-bot commented 1 month ago


     :white_check_mark: bert-mrpc-onnx: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert-mrpc-tf: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance
     :white_check_mark: torchvision-resnet50_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-dpn92_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-resnext101_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance
     :white_check_mark: agentmodel: PASSED: MIGraphX meets tolerance
     :white_check_mark: unet: PASSED: MIGraphX meets tolerance
     :white_check_mark: resnet50v1: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert_base_cased_fp16: PASSED: MIGraphX meets tolerance
:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

     :white_check_mark: bert_large: PASSED: MIGraphX meets tolerance
     :white_check_mark: yolov5s: PASSED: MIGraphX meets tolerance
     :white_check_mark: tinyllama: PASSED: MIGraphX meets tolerance
     :white_check_mark: vicuna-fastchat: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-encoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-decoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: distilgpt2_fp16: PASSED: MIGraphX meets tolerance