ROCm / AMDMIGraphX

AMD's graph optimization engine.
https://rocm.docs.amd.com/projects/AMDMIGraphX/en/latest/
MIT License
185 stars 86 forks source link

Dont use global counter in fuse_mlir #3511

Closed pfultz2 closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.02%. Comparing base (0d07c21) to head (1718a9c). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3511 +/- ## ======================================== Coverage 92.02% 92.02% ======================================== Files 509 509 Lines 21014 21014 ======================================== Hits 19339 19339 Misses 1675 1675 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TedThemistokleous commented 1 month ago

LGTM- Kicked off CI for you

migraphx-bot commented 1 month ago
Test Batch Rate new
1718a9
Rate old
0d07c2
Diff Compare
torchvision-resnet50 64 3,260.07 3,260.52 -0.01% :white_check_mark:
torchvision-resnet50_fp16 64 6,996.33 6,982.39 0.20% :white_check_mark:
torchvision-densenet121 32 2,431.65 2,430.89 0.03% :white_check_mark:
torchvision-densenet121_fp16 32 4,067.97 4,067.06 0.02% :white_check_mark:
torchvision-inceptionv3 32 1,638.80 1,636.77 0.12% :white_check_mark:
torchvision-inceptionv3_fp16 32 2,761.12 2,755.18 0.22% :white_check_mark:
cadene-inceptionv4 16 776.52 775.67 0.11% :white_check_mark:
cadene-resnext64x4 16 808.25 808.09 0.02% :white_check_mark:
slim-mobilenet 64 7,532.25 7,531.83 0.01% :white_check_mark:
slim-nasnetalarge 64 211.46 211.39 0.03% :white_check_mark:
slim-resnet50v2 64 3,501.48 3,495.72 0.16% :white_check_mark:
bert-mrpc-onnx 8 1,147.83 1,140.79 0.62% :white_check_mark:
bert-mrpc-tf 1 452.34 447.09 1.17% :white_check_mark:
pytorch-examples-wlang-gru 1 423.33 357.24 18.50% :high_brightness:
pytorch-examples-wlang-lstm 1 400.93 320.71 25.01% :high_brightness:
torchvision-resnet50_1 1 802.90 776.99 3.33% :high_brightness:
cadene-dpn92_1 1 400.16 430.45 -7.04% :red_circle:
cadene-resnext101_1 1 374.00 378.42 -1.17% :white_check_mark:
onnx-taau-downsample 1 341.69 341.70 -0.00% :white_check_mark:
dlrm-criteoterabyte 1 33.32 32.05 3.95% :high_brightness:
dlrm-criteoterabyte_fp16 1 52.74 50.61 4.20% :high_brightness:
agentmodel 1 10,311.77 6,696.76 53.98% :high_brightness:
unet_fp16 2 58.84 58.59 0.43% :white_check_mark:
resnet50v1_fp16 1 913.33 840.65 8.64% :high_brightness:
resnet50v1_int8 1 973.05 931.26 4.49% :high_brightness:
bert_base_cased_fp16 64 1,172.24 1,170.54 0.15% :white_check_mark:
bert_large_uncased_fp16 32 363.07 363.52 -0.12% :white_check_mark:
bert_large_fp16 1 198.76 196.02 1.40% :white_check_mark:
distilgpt2_fp16 16 2,195.31 2,199.51 -0.19% :white_check_mark:
yolov5s 1 543.04 536.04 1.30% :white_check_mark:
tinyllama 1 43.48 43.33 0.34% :white_check_mark:
vicuna-fastchat 1 172.97 171.81 0.68% :white_check_mark:
whisper-tiny-encoder 1 418.17 416.70 0.35% :white_check_mark:
whisper-tiny-decoder 1 426.36 418.85 1.79% :white_check_mark:

This build is not recommended to merge :red_circle:

migraphx-bot commented 1 month ago


     :white_check_mark: bert-mrpc-onnx: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert-mrpc-tf: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance
     :white_check_mark: pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance
     :white_check_mark: torchvision-resnet50_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-dpn92_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: cadene-resnext101_1: PASSED: MIGraphX meets tolerance
     :white_check_mark: dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance
     :white_check_mark: agentmodel: PASSED: MIGraphX meets tolerance
     :white_check_mark: unet: PASSED: MIGraphX meets tolerance
     :white_check_mark: resnet50v1: PASSED: MIGraphX meets tolerance
     :white_check_mark: bert_base_cased_fp16: PASSED: MIGraphX meets tolerance
:red_circle:bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

     :white_check_mark: bert_large: PASSED: MIGraphX meets tolerance
     :white_check_mark: yolov5s: PASSED: MIGraphX meets tolerance
     :white_check_mark: tinyllama: PASSED: MIGraphX meets tolerance
     :white_check_mark: vicuna-fastchat: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-encoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: whisper-tiny-decoder: PASSED: MIGraphX meets tolerance
     :white_check_mark: distilgpt2_fp16: PASSED: MIGraphX meets tolerance

pfultz2 commented 1 month ago

This is a blocker for #3513 and #3507.