codecov[bot]
commented
2 weeks ago Codecov Report
Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 92.14%. Comparing base (
3c3d007) to head (f38b449). Report is 18 commits behind head on develop.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/onnx/parse_resize.cpp | 95.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #3563 +/- ## =========================================== - Coverage 92.16% 92.14% -0.03% =========================================== Files 512 512 Lines 21401 21422 +21 =========================================== + Hits 19724 19739 +15 - Misses 1677 1683 +6 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
migraphx-bot
The old logic stepped through the args list in order, then assumed the first float-type input was the "Scales". This led to an error in an obscure case where the "ROIs" input, which is not supported by MigraphX, was not left empty and was thereby misinterpreted.
Changed logic to simply refer to the inputs by array reference; means we're allowed to assume that positional inputs all exist even if they're given as blank
''quotes.Updated a few parsing tests to include correct blank positional inputs.
The reason for the older args parsing was apparently an effort to cover the fact that Resize requires one but not both of inputs
scalesandsizeswhich are of different types, and someone thought that positional arguments could not be guaranteed.