search

ROCm / DeepSpeed

DeepSpeed is a deep learning optimization library that makes distributed training easy, efficient, and effective.
https://www.deepspeed.ai/
Apache License 2.0
5 stars 3 forks source link

THC header fix #54

Closed rraminen closed 2 years ago

rraminen commented 2 years ago

Filing this PR to avoid 'THH/THHGeneral.h' file not found error error during DeepSpeed build.

Used rocm/pytorch:rocm4.5.2_ubuntu18.04py3.8pytorch_1.9.0 for testing DeepSpeed with old PyTorch vesion. There were no issues.

Fixes https://ontrack-internal.amd.com/browse/SWDEV-321538

This issue occurs as THC/THCGeneral.h is deprecated. Reference: https://github.com/pytorch/pytorch/pull/66391/files

cc: @jithunnair-amd

jithunnair-amd commented 2 years ago

retest this please