search

ROCm / HIP-Examples

Examples for HIP
194 stars 86 forks source link

Update OpenMP Hello World #29

Closed aaronenyeshi closed 3 years ago

aaronenyeshi commented 3 years ago

Add functionality for openmp_helloworld project to build on Windows, using MSVC's C++ Clang Tools' OpenMP library.

aaronenyeshi commented 3 years ago

Okay but this is pulling the MSVC llvm openmp, I didn't install clang support as didn't want to mix two clangs so don't even have a llvm/x64/lib, only llvm/x64/bin (no libomp.dll). Is the standard MSVC vcomp.dll not compatible? C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\lib\x64\vcomp.lib Maybe you needed the llvm openmp to launch kernels within the omp threads? This is fine to install the clang tools but just want to confirm.

It may be more compatible to MSVC's llvm openmp library. But will need time to scope out how to use vcomp instead.

TorreZuk commented 3 years ago

As Dan pointed out VS will have an updated OpenMP soon, I don't see this in my version yet: https://devblogs.microsoft.com/cppblog/improved-openmp-support-for-cpp-in-visual-studio/ Should compare against what llvm OpenMP will have...

aaronenyeshi commented 3 years ago

As Dan pointed out VS will have an updated OpenMP soon, I don't see this in my version yet: https://devblogs.microsoft.com/cppblog/improved-openmp-support-for-cpp-in-visual-studio/ Should compare against what llvm OpenMP will have...

I believe once the default MSVC supports OpenMP with -openmp:llvm, we can switch this example to using that instead.

aaronenyeshi commented 3 years ago

If this is okay, I will submit it.