not all "pi" functions present in ROCm math library are available through hipcc

ROCm / HIP

HIP: C++ Heterogeneous-Compute Interface for Portability

https://rocmdocs.amd.com/projects/HIP/

MIT License

3.68k stars 527 forks source link

not all "pi" functions present in ROCm math library are available through hipcc #3335

Open VinInn opened 11 months ago

VinInn commented 11 months ago

ROCm math library implements all "pi" functions: sinpi, cospi, tanpi and their inverse (including atan2pi) hip seems to provide access only to sinpi and cospi.

see https://github.com/RadeonOpenCompute/ROCm-Device-Libs/issues/99

cjatin commented 11 months ago

Will raise it internally. Open it up to broader discussion since if we add it, it will be supported for a long time.

yxsamliu commented 11 months ago

It seems we should not document that tanpi is supported.

tanpi is not declared by CUDA SDK https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#mathematical-functions-appendix .

ppanchad-amd commented 4 months ago

@VinInn Is this ticket still relevant? Thanks!

VinInn commented 4 months ago

It would be useful to have all math functions implemented in the device library available through hipcc. I do understand that at the moment strict compatibility with the CUDA SDK is instead preferred.