search

ROCm / HIP

HIP: C++ Heterogeneous-Compute Interface for Portability
https://rocmdocs.amd.com/projects/HIP/
MIT License
3.54k stars 518 forks source link

Update C++ language extensions #3488

Closed matyas-streamhpc closed 1 month ago

tomsang commented 1 month ago

I have a few comments. Please update PR accordingly.

neon60 commented 1 month ago

@matyas-streamhpc rebased your branch and targeted docs/develop

matyas-streamhpc commented 1 month ago

"hipLaunchParm lp, " should be removed here, // Example hipLaunchKernelGGL pseudocode: global MyKernel(hipLaunchParm lp, float A, float B, float *C, size_t N) { ... }

It has been fixed in https://github.com/ROCm/HIP/pull/3488/commits/3be5ac382846443cbcb647734890b6932b649222 (former https://github.com/ROCm/HIP/pull/3488/commits/d518b3a9e4955074b1535a1f8f6b4ed4524bc794)

matyas-streamhpc commented 1 month ago

@matyas-streamhpc rebased your branch and targeted docs/develop

Rebased again.