ROCm / HIP

HIP: C++ Heterogeneous-Compute Interface for Portability
https://rocmdocs.amd.com/projects/HIP/
MIT License
3.54k stars 518 forks source link

Add Unified Memory #3494

Closed matyas-streamhpc closed 3 days ago

neon60 commented 1 month ago

Send some comments via direct message. The short summary:

neon60 commented 1 month ago

@matyas-streamhpc Please rebase your branch on docs/develop

neon60 commented 2 weeks ago

@matyas-streamhpc rebased the branch.

Rmalavally commented 2 weeks ago

@neon60 Looks good. Some editorial tweaks:

Document structure

We have not explained Explicit memory management in the document. It would be good to list the differences between EMM and UMM. Could you consider adding the description after the visual?

Rmalavally commented 2 weeks ago

@neon60 Could you please provide the context for the Compiler Hints for Better Performance section? How does it relate to UMM? Do you mean C++ Compiler hints for better performance?

Rmalavally commented 2 weeks ago

@matyas-streamhpc Can we update the visual to include APU for context as an example of UMM architecture?

Rmalavally commented 2 weeks ago

@matyas-streamhpc @yhuiYH added some comments from a user standpoint. Please feel free to use or ignore them. Let me know if they are not technically applicable or relevant.

matyas-streamhpc commented 2 weeks ago

@matyas-streamhpc @yhuiYH added some comments from a user standpoint. Please feel free to use or ignore them. Let me know if they are not technically applicable or relevant.

@Rmalavally @yhuiYH Thank you very much for your feedback. I updated the page, accordingly.

neon60 commented 2 weeks ago

Please fix the following rst issues:

HIP\docs\reference\unified_memory_reference.rst:12: WARNING: Duplicate C++ declaration, also defined at reference/unified_memory_reference:10.
Declaration is '.. cpp:function:: hipError_t hipMallocManaged (void **dev_ptr, size_t size, unsigned int flags)'.
HIP\docs\reference/unified_memory_reference.rst:8: CRITICAL: Duplicate ID: "group___memory_m_1gaadf4780d920bb6f5cc755880740ef7dc".
HIP\docs\reference/unified_memory_reference.rst:8: WARNING: Duplicate explicit target name: "group___memory_m_1gaadf4780d920bb6f5cc755880740ef7dc".
HIP\docs\reference/unified_memory_reference.rst:15: WARNING: doxygenfunction: Cannot find function "hipMemoryAdvise" in doxygen xml output for project "HIP 6.2.0 Documentation" from directory: HIP\docs\doxygen\xml
HIP\docs\reference/unified_memory_reference.rst:17: WARNING: doxygenfunction: Cannot find function "hipMemRangeAttribute" in doxygen xml output for project "HIP 6.2.0 Documentation" from directory: HIP\docs\doxygen\xm