search

ROCm / HIPIFY

HIPIFY: Convert CUDA to Portable C++ Code
MIT License
442 stars 69 forks source link

[HIPIFY][Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh #1474

Open mcordery opened 1 month ago

mcordery commented 1 month ago

Problem Description

In working on porting a library, I've run in to the situation where I'm only making use of the header files in a library (e.g. .h, .cuh) and none of the .cu files which may only be tests or library code that I'm not making use of. It would be nice if hipifyconvertinplace.sh had the ability to take a flag, e.g. --convert-headers-only, that could be passed to findcode.sh. This would provide the benefits of

  1. reducing the amount of translation time, sometimes significantly
  2. reducing the amount of output that needs to be parsed for errors/warnings about things that need to be addressed.

Operating System

Ubuntu

CPU

Intel

ROCm Version

ROCm 6.0.0

ROCm Component

HIPIFY

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

emankov commented 1 month ago

Hello @mcordery,

I don't quite understand the aims of the supposed --convert-headers-only. Is the goal just to reduce the hipification time (hipify-clang, hipify-perl, both?), or is hipification of the source codes is not needed in fact?

mcordery commented 1 month ago

[AMD Official Use Only - AMD Internal Distribution Only]

It would just reduce the time to hipify everything if you didn’t need the repo’s .cu files at all. We’re in the process of porting a bunch of nvidia repos to hip and generally all we need are the header files but sometimes there can be a lot of .cu files either through library code that we don’t need or extensive test files that we don’t need.

From: Evgeny Mankov @.> Sent: Thursday, May 16, 2024 11:24 AM To: ROCm/HIPIFY @.> Cc: Cordery, Matthew @.>; Mention @.> Subject: Re: [ROCm/HIPIFY] [Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh (Issue #1474)

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

Hello @mcorderyhttps://github.com/mcordery,

I don't quite understand the aims of the supposed --convert-headers-only. Is the goal just to reduce the hipification time (hipify-clang, hipify-perl, both?), or is hipification of the source codes is not needed in fact?

— Reply to this email directly, view it on GitHubhttps://github.com/ROCm/HIPIFY/issues/1474#issuecomment-2115816185, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEJ5XWL6CRAK2WI6WIDLSW3ZCTTUVAVCNFSM6AAAAABHJWZOYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHAYTMMJYGU. You are receiving this because you were mentioned.Message ID: @.**@.>>