Dedicated primitive (e.g. `Fused`) for fused convolutions?

ROCm / MIOpen

AMD's Machine Intelligence Library

https://rocm.docs.amd.com/projects/MIOpen/en/latest/

Other

1.07k stars 224 forks source link

Dedicated primitive (e.g. `Fused`) for fused convolutions? #1213

Open atamazov opened 3 years ago

atamazov commented 3 years ago

https://github.com/ROCmSoftwarePlatform/MIOpen/blob/4e61a3ebdfe2b07b4d331cc46832eb4a6b49941c/src/solver.cpp#L264

Can we introduce some dedicated primitive (e.g. Fused) for fused convolutions and use it in the registry? This would help to avoid hacks like this: https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1212/files/db05b058f77cc838f5bbafc93fe08fd8e20c713d..f26346d12ba5f2ee472d26d7e6c207325bbe6233#r723662796

ppanchad-amd commented 6 months ago

@DrizztDoUrden Has this been resolved? Thanks!

DrizztDoUrden commented 5 months ago

@ppanchad-amd No, but I can take it if we consider it valuable and urgent. Do we? It is a trivial thing to do, but merging any PR takes quite some time.