search

ROCm / MIOpen

AMD's Machine Intelligence Library
https://rocm.docs.amd.com/projects/MIOpen/en/latest/
Other
1.08k stars 230 forks source link

Get rid of W/A: HIP kernels disabled for embedded builds #1252

Open atamazov opened 3 years ago

atamazov commented 3 years ago

There were times when HIP compilation didn't work in embedded MIOpen, because precompiled HIP headers weren't available.

https://github.com/ROCmSoftwarePlatform/MIOpen/blob/5cb2e548131d777d589917db8a0d8669b3ae8c5d/CMakeLists.txt#L132-L135

This workaround leads to performance drop of embedded MIOpen.

We should remove this (or make it dependent on HIP version).

:warning: HIP PCH is broken in 4.5.

ppanchad-amd commented 7 months ago

@atamazov Is this fixed as of latest ROCm 6.0.2 (HIP 6.0.32831)? Thanks!