ROCm / MIOpen

AMD's Machine Intelligence Library
https://rocm.docs.amd.com/projects/MIOpen/en/latest/
Other
1.01k stars 210 forks source link

Deprecate some old static solvers for new ASICs #2080

Open atamazov opened 1 year ago

atamazov commented 1 year ago

Some clarifications: https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2072#discussion_r1159102468


[Attribution] @junliume @johnny-keker https://github.com/ROCmSoftwarePlatform/MIOpen/labels/specification https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_high

atamazov commented 1 year ago

[attribution] @JehandadKhan I think that this is https://github.com/ROCm/MIOpen/labels/urgency_low https://github.com/ROCm/MIOpen/labels/value_low. All that's left is to remove the solvers (which may only happen in the future)

atamazov commented 3 weeks ago

@junliume @JehandadKhan @Kirpich30000 As shown at https://github.com/ROCm/MIOpen/issues/2492#issuecomment-1911121477, ConvOclBwdWrW2<*> deliver good performance (especially with grouped configs). Shall we consider excluding these from the list of deprecated solvers?

FYI quote from https://github.com/ROCm/MIOpen/issues/2492#issuecomment-1919952275:

Maybe it is worth enabling ConvOclBwdWrW2<*> for the new GPUs to avoid inadequate performance of WrW convolutions, especially when n_groups > 1 (we can even enable them only for group convolutions).