Post #2334 Merge Issue: Reference kernel for 3D convolution for non-packed tensors

[junliume]

UPDATE:

In discussion with @JehandadKhan, we decided not to include strides of non-packed tensors to the database keys. Only an optional flag (saying that at least one tensor is non-packed) should be included there. The above means that databases will share the same find-db records, same Invoker instances and same perf-db information for the non-packed convolutions that differ only in strides.

The above design should work correctly provided that:

• If an Invoker instance is able to compute some non-packed convolution, then the same instance must be able to compute any similar non-packed convolution that differs only in strides.
  • [Consequence 1] An Invoker that is used for computation of non-packed convolutions must read stride information from DataInvokeParams (passed to Invoker) and pass it to the kernels as run-time parameters.
  • [Consequence 2] Stride information should not be used for building any compile-time parameters.
• If a kernel that is used to compute a non-packed convolution requires tuning, then the same tuning parameters must provide similar performance for non-packed convolutions that differs only in strides.

From now on, the above is becoming a part of the Solver/Solution/Invoker specification.

@amberhassaan @junliume

_Originally posted by @atamazov in https://github.com/ROCmSoftwarePlatform/MIOpen/pull/2334#discussion_r1348090910_

[junliume]

@atamazov to add more necessary details here

[atamazov]

Unresolved review comments:

• [ ] https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_blocker Update database keys with some stride information
  • I.e. an optional flag that says that at least one tensor is non-packed
• [ ] https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_normal Usage of old "packed" naive kernels
• [ ] https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_normal Do not set C++17 for HIP kernels globally
• [ ] https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_low Test for one datatype
• [ ] https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_low "Endianness"
• [ ] https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_low Namespace for ConvNaive specific stuff

@junliume Thanks for opening the issue. I recommend cleaning the topmost comment (issue description) as it is obsolete now.