ROCm / MIOpen

AMD's Machine Intelligence Library
https://rocm.docs.amd.com/projects/MIOpen/en/latest/
Other
1.06k stars 221 forks source link

Implement serialization of tensor descriptors and use it in primitives. #2812

Open atamazov opened 6 months ago

atamazov commented 6 months ago

_Originated from: https://github.com/ROCm/MIOpen/pull/2782#discussion_r1515323515_

It may worth extending the common tensor descriptor abstraction to support serialization (with custom prefix). This would allow for uniform serialization of TDs in different primitives + for removal of duplicated code. Currently each primitive uses its own code for serialization of TDs.


[Attribution] @junliume @JehandadKhan

atamazov commented 6 months ago

The exception is convolutions, where I would like to keep the current implementation of serialization of TDs for the sake of backward compatibility. When/if we decide to drop bwd compatibility of conv databases, we can switch to common machinery.