search

ROCm / MIOpen

AMD's Machine Intelligence Library
https://rocm.docs.amd.com/projects/MIOpen/en/latest/
Other
1.09k stars 231 forks source link

Add gtest name checker #3218

Closed CAHEK7 closed 3 months ago

CAHEK7 commented 3 months ago

Closes #3148 Right now it does not force test naming, since most of the tests do not fit into scheme. Enforcing this check will be a separated PR when #3133 will be done.

Byproduct is a regression test for #3202

@atamazov @Vsevolod1983 @xinlipn

CAHEK7 commented 3 months ago

@junliume @reidkwja @cderb @JehandadKhan does anybody know why CI did not start automatically?

CAHEK7 commented 3 months ago

my only thought is that we should create helper functions to generate the test name in the correct format.

e.g.,

TEST_P(MakeTestName(X, Y, Z), MakeSuiteName(...))

Unfortunately it's not about the name in TEST_P, it's about class name as well. I'm afraid that C++ code will be much uglier if we introduce one more macro level over the current TEST_P - MakeTestName must reside in 3 or more places, it will break code navigation (because for IDE point of view there is no class names or even names), and we can't enforce naming scheme there (without some special dark macro magic or even the magic won't help).

I feel like the outcome does not worth the effort,

CAHEK7 commented 3 months ago

@junliume Packaging stage passed and worked as expected, any other stages are not affected - it's just a python script for a newly added make target for a specific packaging stage.