search

ROCm / MIOpen

AMD's Machine Intelligence Library
https://rocm.docs.amd.com/projects/MIOpen/en/latest/
Other
1.09k stars 230 forks source link

[GTests Refactoring] Removing MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables. Part 1. #3269

Closed Vsevolod1983 closed 2 months ago

Vsevolod1983 commented 2 months ago

Part 1.

Base branch for this PR is GTests_Refactoring_Integration_Branch

junliume commented 2 months ago

Is the target branch [GTests_Refactoring_Integration_Branch](https://github.com/ROCm/MIOpen/tree/GTests_Refactoring_Integration_Branch) ?

Vsevolod1983 commented 2 months ago

Is the target branch [GTests_Refactoring_Integration_Branch](https://github.com/ROCm/MIOpen/tree/GTests_Refactoring_Integration_Branch) ?

Yes it is. We decided to use separate branch for our GTests refactoring efforts until we collect all necessary changes. When we collect them we will merge this branch to the develop

junliume commented 2 months ago

Is the target branch [GTests_Refactoring_Integration_Branch](https://github.com/ROCm/MIOpen/tree/GTests_Refactoring_Integration_Branch) ?

Yes it is. We decided to use separate branch for our GTests refactoring efforts until we collect all necessary changes. When we collect them we will merge this branch to the develop

Maybe update the target branch with merging the latest develop branch will help with the CI. Thanks!

Vsevolod1983 commented 2 months ago

Is the target branch [GTests_Refactoring_Integration_Branch](https://github.com/ROCm/MIOpen/tree/GTests_Refactoring_Integration_Branch) ?

Yes it is. We decided to use separate branch for our GTests refactoring efforts until we collect all necessary changes. When we collect them we will merge this branch to the develop

Maybe update the target branch with merging the latest develop branch will help with the CI. Thanks!

yeah, I update it periodically.

Btw, we would like to merge PRs into this temporary branch by ourselves. No objections from you ?